Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure proper JVM shutdown #25

Merged
merged 1 commit into from
Oct 7, 2012
Merged

ensure proper JVM shutdown #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/main/scala/execution.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,18 @@ class Http extends FixedThreadPoolExecutor { self =>
}
}

// produce thread(daemon=true), so it doesn't block JVM shutdown
class DaemonThreadFactory extends juc.ThreadFactory {
def newThread(r: Runnable):Thread ={
val thread = new Thread
thread.setDaemon(true) // this ensure the created threads don't prevent jVM from porpoer shutdown
thread
}
}

trait FixedThreadPoolExecutor extends Executor {
def threadPoolSize: Int
lazy val promiseExecutor = juc.Executors.newFixedThreadPool(threadPoolSize)
lazy val promiseExecutor = juc.Executors.newFixedThreadPool(threadPoolSize,new DaemonThreadFactory)
}

trait Executor { self =>
Expand Down