Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding titlePath in bridge to handle reporting of test failures #7

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Adding titlePath in bridge to handle reporting of test failures #7

merged 1 commit into from
Jan 22, 2018

Conversation

MiguelCastillo
Copy link

This code changes resolve an issue where tests that fail report

  1 failing

Fatal error: test.titlePath is not a function

After these changes I get the expected trace.

  1 failing

  1) Fetch Test Suite
       When loading modules by name
         When fetching a single module called `like`
           then then result is an object:
     expected [ Array(1) ] to be an object
  AssertionError
  assert
  an
  chainableMethodWrapper
  
  runHandler@http://localhost:54232/node_modules/spromise/dist/spromise.min.js:1:5831
  http://localhost:54232/node_modules/spromise/dist/spromise.min.js:1:5718
  c@http://localhost:54232/node_modules/spromise/dist/spromise.min.js:1:5178
  _runTask@http://localhost:54232/node_modules/spromise/dist/spromise.min.js:1:6923
  http://localhost:54232/node_modules/spromise/dist/spromise.min.js:1:6881

This fixes #6

@BYK
Copy link

BYK commented Jan 21, 2018

LGTM!

Do you know why this wasn't an issue earlier?

@BYK
Copy link

BYK commented Jan 21, 2018

@tail can you rerun the tests to make sure they pass?

@tail tail merged commit ada8c23 into disqus:master Jan 22, 2018
@MiguelCastillo MiguelCastillo deleted the undefined-test-titlepath branch January 22, 2018 19:26
@Spongman
Copy link

what's the holdup? can we get this on npm already?

@rejas
Copy link

rejas commented May 4, 2018

Would like to see this released too. Any help needed @BYK ?

@BYK
Copy link

BYK commented May 13, 2018

@rejas you need to ping @tail or @thekashifmalik for that :)

@rejas
Copy link

rejas commented May 13, 2018

Pinging @tail and @thekashifmalik asking them if they need help releasing this...

@rejas
Copy link

rejas commented May 23, 2018

Hello @tail and @thekashifmalik if you read this, please provide an update of this plugin to npm. Or if you dont have time for that, consider granting the rights for that to another person. Thx in advance.

@rejas
Copy link

rejas commented May 24, 2018

hi again @BYK seems like the two have not been active on github for several weeks, is there any other way to move this issue forward?

@BYK
Copy link

BYK commented May 24, 2018

I have pinged then from another channel and they said they should have time next week to push this 😉

@rejas
Copy link

rejas commented Jun 1, 2018

Any news from them?

@MiguelCastillo
Copy link
Author

@tail @thekashifmalik - all of us here know that it is really difficult to find time for open source projects that we have volunteered to do in our spare time. I personally really appreciate that y'all have stepped up to take this on. But given the current rate of responses to publish this to npm it seems prudent (and only fair to the community) to add a few folks in here as collaborator in NPM so that we can at least publish from a fork if y'all dont have time to continue maintenance of this project. Please! ❤️

@thekashifmalik
Copy link

Hey all.

Sorry about the long time-to-response. I wanted to get perms on NPM first.

I just got said permissions on the NPM repository for this project. I'll try and make a release ASAP.(probably look into it tomorrow)

@rejas
Copy link

rejas commented Jun 14, 2018

Thx for the headsup. Not wanting to sound too pushy but would it be possible to get this #9 in the release too? Would be really helpful to have the new reelease without the need of having to install growl...

@thekashifmalik
Copy link

It says merging is blocked but let me see if it's easy to fix.

@rejas
Copy link

rejas commented Jun 15, 2018

Somebody with review-priviliges needs to review the PR before it can get merged. I hope you do have those :-)

@thekashifmalik
Copy link

@rejas @MiguelCastillo: version 1.0.5 is now published on NPM: https://www.npmjs.com/package/grunt-mocha.

I'll make another release once I fix my permission on Github and can merge #9.

@rejas
Copy link

rejas commented Jun 16, 2018

Thx for publishing. Git sources are not updated yet though?

@thekashifmalik
Copy link

thekashifmalik commented Jun 16, 2018 via email

@thekashifmalik
Copy link

All good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test.titlePath not implemented
6 participants