patch grunt-mocha to fix 'test.titlePath' errors on test failure

[Spongman]

re: #2648, #2746, disqus/grunt-mocha#6, disqus/grunt-mocha#7,

this PR patches the grunt-mocha package with fixes so that test failures will now display the actual failure information instead of some internal test.titlePath is not a function error.

[limzykenneth]

Seems like a good solution until we can maybe migrate to something that is either better maintained or something that doesn't rely on plugins so much.

[Spongman]

indeed. somewhere i have a branch that uses headless-chrome for the test runner, but i had a bunch of issues with it not detecting properly when the process had ended.

[meiamsome]

Alternate option: use the git url in the package.json (Preferably pinned to the particular commit) until this is published

[Spongman]

That is possible. I'd have to create a fork and another branch since there's also the growl fix that isn't part of that grunt-mocha PR.

[meiamsome]

@Spongman can you explain what the growl fix achieves? Surely the previous code goes through the catch section and sets it to an empty function anyway?

[Spongman]

Actually the require succeeds, but then growl just crashes when the test fails, so I just removed it.

[meiamsome]

Hmm, that's a bit odd considering growl isn't in the deps. Do you have it on global install? Could be a version mismatch if so.
I'd never even consider that there'd be such issues when not including an optional dependency...

[Spongman]

i get this:

> yarn why growl
yarn why v1.5.1
[1/4] Why do we have the module "growl"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "growl@1.10.3"
info Reasons this module exists
   - "grunt-mocha#mocha" depends on it
   - Hoisted from "grunt-mocha#mocha#growl"

and this when a test fails:

>> 1/561 tests failed (134.68s)
An error occured. { Error: spawn growlnotify ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:201:19)
    at onErrorNT (internal/child_process.js:379:16)
    at process._tickCallback (internal/process/next_tick.js:178:19)
  errno: 'ENOENT',
  code: 'ENOENT',
  syscall: 'spawn growlnotify',
  path: 'growlnotify',
  spawnargs:
   [ '/i:E:\\play\\p5.js\\node_modules\\grunt-mocha\\growl\\error.png',
     '1/561 tests failed (134.68s)',
     '/t:Failure in yui' ] }
An error occured. { Error: spawn growlnotify ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:201:19)
    at onErrorNT (internal/child_process.js:379:16)
    at process._tickCallback (internal/process/next_tick.js:178:19)
  errno: 'ENOENT',
  code: 'ENOENT',
  syscall: 'spawn growlnotify',
  path: 'growlnotify',
  spawnargs:
   [ '/i:E:\\play\\p5.js\\node_modules\\grunt-mocha\\growl\\error.png',
     '1/561 tests failed (134.68s)',
     '/t:1/561 tests failed (134.68s)' ] }
Warning: Task "mocha:yui" failed. Use --force to continue.

Aborted due to warnings.
error An unexpected error occurred: "Command failed.
Exit code: 3
Command: C:\\WINDOWS\\system32\\cmd.exe
Arguments: /d /s /c grunt --quiet
Directory: E:\\play\\p5.js
Output:
".
info If you think this is a bug, please open a bug report with the information provided in "E:\\play\\p5.js\\yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

growl is not installed globally.

[Spongman]

any chance we can get this merged so we can actually see test errors in travis?

[lmccart]

thank you. as a reminder, issues need to be opened before pull requests are opened and tagged with the issue. this is necessary for tracking development and keeping discussion clear. thanks!

[Spongman]

am I missing something here? I listed two issues above that this fix addresses.

[Spongman]

Here's another: #2812

[lmccart]

please open an issue that documents the specific problem you're solving with this pr. if it's solving a related point that comes up in a completely separate issue thread it is difficult to track. thanks.

[Spongman]

closes #2820