Skip to content

Commit

Permalink
Add warnings to JIRA auth provider that we only support JIRA 6
Browse files Browse the repository at this point in the history
Summary: Ref T4289. Make it clear that this provider does not currently work with JIRA 5.

Test Plan: Viewed JIRA provider from `/auth/`, saw warnings.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T4289

Differential Revision: https://secure.phabricator.com/D7906
  • Loading branch information
epriestley committed Jan 8, 2014
1 parent 2e6332f commit 3524ba3
Showing 1 changed file with 9 additions and 0 deletions.
Expand Up @@ -11,6 +11,10 @@ public function getProviderName() {
return pht('JIRA');
}

public function getDescriptionForCreate() {
return pht('Configure JIRA OAuth. NOTE: Only supports JIRA 6.');
}

public function getConfigurationHelp() {
if ($this->isSetup()) {
return pht(
Expand Down Expand Up @@ -162,6 +166,11 @@ public function extendEditForm(
"again."));
}

$form->appendRemarkupInstructions(
pht(
'NOTE: This provider **only supports JIRA 6**. It will not work with '.
'JIRA 5 or earlier.'));

$is_setup = $this->isSetup();

$e_required = $request->isFormPost() ? null : true;
Expand Down

0 comments on commit 3524ba3

Please sign in to comment.