This repository has been archived by the owner on Feb 27, 2021. It is now read-only.
BASE dump import and optimizations for speed #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When importing papers that are already there and do not need updating, this code runs at ~ 600 papers/sec in the sandbox. I think we should start running this in production to import the missing papers. |
Phyks
approved these changes
May 15, 2019
Phyks
reviewed
May 15, 2019
|
The tests are passing. In the OaiRecords from BASE we have irregular pubtypes The last one seems to come from the fact that on production the value is not set, but the to other seem mysterious to me at the moment. I'd like to investigate this, then we can probably merge and correct our incorrect types. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we didn't even have some code to import a dump, not sure exactly where this went… This is some incremental progress towards being able to stay in sync more efficiently with BASE.