fio: convert to json for metric data #512
Conversation
Use same libaries uperf uses to process data
| @@ -641,8 +604,6 @@ function fio_run_benchmark() { | |||
| for block_size in `echo $block_sizes | sed -e s/,/" "/g`; do | |||
| job_num=1 | |||
| iteration="${count}-${test_type}-${block_size}KiB" | |||
|
|
|||
| echo $iteration >> $benchmark_iterations | |||
There was a problem hiding this comment.
@ndokos, don't we need this now? Or is this being replaced by another method?
There was a problem hiding this comment.
Yes, but the record_iteration function is not in master yet (only in wip-indexing). I'l fix this up after I PR the iterations commit.
| fi | ||
| benchmark_iterations="$pbench_tmp/${benchmark_fullname}.iterations" |
There was a problem hiding this comment.
I think we need this for the indexing work. Is there a replacement for this?
There was a problem hiding this comment.
I am not sure, but adding it back should not be a problem for this PR
| } else { | ||
| print "$script: could not find any directories in $tool_group_dir which matched $tool_label_pattern\n"; | ||
| } | ||
| closedir $dh; |
There was a problem hiding this comment.
Should the closedir() be in the if branch? I get complaints about invalid dir handles.
There was a problem hiding this comment.
You are correct, it should be moved within the branch
|
We'll need to add the Switch.PM module as a dependency to the RPM. We'll also need to add it the Travis environment for unit testing. |
|
Superseded by PR #590. |
Use same libaries uperf uses to process data