Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove blobstore for schema2 builder #2150

Closed
dmcgowan opened this issue Jan 18, 2017 · 3 comments · Fixed by #3896
Closed

Remove blobstore for schema2 builder #2150

dmcgowan opened this issue Jan 18, 2017 · 3 comments · Fixed by #3896
Labels
help wanted
Milestone
Registry/3.0.0

Comments

@dmcgowan
Copy link
Collaborator

Currently the schema2 builder is initialized with a blobstore. This blobstore is only used to get the size of the configuration digest to put in the schema2 manifest. Since we already require the media type in creating the builder, it would be cleaner to take in the config descriptor and completely remove the blobstore from the schema2 builder.
@dmcgowan dmcgowan added this to the Registry/2.7 milestone Jan 18, 2017
@dmcgowan dmcgowan modified the milestones: Registry/2.7, Registry/2.8 Sep 13, 2018
@glefloch
Copy link
Contributor

glefloch commented Dec 6, 2018 •
edited
Loading

Hi I started to work on this.

@thaJeztah
Copy link
Member

Thanks!

@glefloch glefloch mentioned this issue Dec 7, 2018
Closed
@davidspek davidspek mentioned this issue May 3, 2023
Merged
@glefloch
Copy link
Contributor

@milosgajdos while rebasing #2782 it automatically closed the pull request as it looks like my commit was already merged in #3896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
Registry/3.0.0
4 participants
@dmcgowan @milosgajdos @thaJeztah @glefloch