Remove blobstore from manifest builder #2782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2782 +/- ##
==========================================
+ Coverage 60.24% 60.26% +0.01%
==========================================
Files 103 103
Lines 8022 8008 -14
==========================================
- Hits 4833 4826 -7
+ Misses 2546 2540 -6
+ Partials 643 642 -1
Continue to review full report at Codecov.
|
|
Hello from the future @glefloch. Would you mind rebasing? |
|
Hello @milosgajdos, sure, I will! |
glefloch
force-pushed
the
clean-blobstore
branch
from
16827ee
to
5bca240
Compare
|
@milosgajdos it should be good now :) |
|
Thanks, @glefloch. I need to allocate some time this week to properly review this PR. |
|
@glefloch can you please rebase? It does not seem to be necessary, but I'd like the workflow to rekick. Thanks! |
|
Sure, done! |
Are you sure? |
|
@glefloch do you mind rebasing 🙇♂️ |
glefloch
force-pushed
the
clean-blobstore
branch
from
49f500e
to
003dd5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #2150 by removing
blobstorefrom schema2 manifest builder.The builder now take configuration
Descriptoras parameter instead of a blobstore and media type.Signed-off-by: glefloch glfloch@gmail.com