Remove blobstore from manifest builder #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidspek
force-pushed
the
clean-blobstore-rebase
branch
from
eb4526b
to
d0b17d4
Compare
|
Friendly ping @thaJeztah @squizzi |
milosgajdos
approved these changes
May 19, 2023
|
@milosgajdos I’ve addressed the nit. |
Signed-off-by: glefloch <glfloch@gmail.com> Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Co-authored-by: Kyle Squizzato <ksquizz@gmail.com> Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
davidspek
force-pushed
the
clean-blobstore-rebase
branch
from
fce45f3
to
f3eb91c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase from #2782
@milosgajdos friendly ping since you were the one to review the original PR.