Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup storage cache metrics #2897

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Cleanup storage cache metrics #2897

merged 1 commit into from
Aug 15, 2023

Commits on Aug 4, 2023

  1. Cleanup storage cache metrics 

    Split request and hit metrics into separate metrics, rather than using
labels. This avoids duplication of data and makes metric math easier.

* Count cache errors separately to avoid weird math.
* Hit ratio: `registry_storage_cache_hits_total / registry_storage_cache_requests_total`
* Miss ratio: `1 - (registry_storage_cache_hits_total / registry_storage_cache_requests_total`
* Misses: `registry_storage_cache_requests_total -
registry_storage_cache_hits_total`

Signed-off-by: Ben Kochie <superq@gmail.com>
    @SuperQ
    SuperQ committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    c19adfd View commit details
    Browse the repository at this point in the history