Un-fork rsc.io/letsencrypt package #2915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @dmcgowan @caervs @manishtomar PTAL |
|
Does the current letsencrypt stuff even still work? I thought they had to make some changes to their certificate request protocol that would require using a new library anyway. |
|
Good question; I saw they removed the challenge that currently looks to be the default in this codebase in go-acme/lego@76cb778 (which is what caused the breaking change in V1.x for the code used in this repository) Perhaps it should be switched to something like https://github.com/mholt/certmagic ? |
|
I am strongly in favor to moving to any other package which does letsencrypt correctly |
|
replaced by #2926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to oras-project/oras#100 (comment)
I also had a very quick look at updating lego to v1.x.x, but there's some breaking changes, so I left that for now. Still something to look into probably if we want to make letsencrypt support useful 😅