migrate to gomodules #100
migrate to gomodules #100
Conversation
fix tag in codefresh yaml fix tag in codefresh yaml rename to main_clone replace inderict dependency rsc.io/letsencrypt with the forked version update to psuedo version of docker/docker wip wip download modules before releasing
|
|
|
|
||
| replace ( | ||
| github.com/docker/docker => github.com/docker/docker v0.0.0-20190131205458-8a43b7bb99cd | ||
| rsc.io/letsencrypt => github.com/dmcgowan/letsencrypt v0.0.0-20160928181947-1847a81d2087 |
There was a problem hiding this comment.
Looking at the changes that were made in the fork (related to vendoring), perhaps the fork is no longer needed if I read the description of this release: https://github.com/rsc/letsencrypt/releases/tag/v0.0.1 (but probably best to make that change he upstream in the github.com/docker/distribution package first)
There was a problem hiding this comment.
Trying to replace it to replace rsc.io/letsencrypt => github.com/rsc/letsencrypt v0.0.1 breaking the tests at github.com/deislabs/oras/pkg/auth/docker
+ go test -v -covermode=atomic -coverprofile=.cover/github.com_deislabs_oras_pkg_auth_docker.cover.out github.com/deislabs/oras/pkg/auth/docker
# rsc.io/letsencrypt
../../../go/pkg/mod/github.com/rsc/letsencrypt@v0.0.1/lets.go:674:41: too many arguments in call to c.ObtainCertificate
have ([]string, bool, nil, bool)
want ([]string, bool, crypto.PrivateKey)
FAIL github.com/deislabs/oras/pkg/auth/docker [build failed]
There was a problem hiding this comment.
Hm, interesting; rsc/letsencrypt@33926fa
looks like that may be due to a different version of https://github.com/go-acme/lego being vendored (see go-acme/lego@01974a9).
Don't think it has top-priority now to get rid of that fork, and it can be done upstream first (in the docker/distribution repository)
There was a problem hiding this comment.
Agree, as long as the model gives reproducibility and availability of the modules.
|
/test |
Related to #99
Changes have to be done
vX.Y.(Z+1)-0.yyyymmddhhmmss-abcdefabcdef)rsc.io/letsencrypthave to be replaced with the forked version using bydocker/distributionhttps://github.com/deislabs/oras/blob/master/Gopkg.toml#L22MakefileGOPATHmake testpassed