Add functionality to make a url signed for a HEAD request to S4 driver #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if method != "GET" && method != "HEAD" { | ||
| return "", storagedriver.ErrUnsupportedMethod | ||
| } | ||
| methodString, _ = method.(string) |
There was a problem hiding this comment.
This will panic if the method is not a string. It should be something like this:
m, ok = method.(string)
if !ok || (m != "GET" && m != "HEAD") {
return "", storagedriver.ErrUnsupportedMethod
}
methodString = m
There was a problem hiding this comment.
It will not, because you will never reach the line if method is not either the string "GET" or the string "HEAD"
There was a problem hiding this comment.
Exactly. That statement continuing to not crash relies on a side-effect of the if statement above. If this condition gets changed in any way such that the guarantee is removed, it will crash, unexpectedly.
AndreyKostov
force-pushed
the
add-urlfor-method-param
branch
from
a389bf2
to
bdd5d35
Compare
|
Waiting on LGTM from @BrianBland. |
|
LGTM, I'll submit a PR in a moment with the remaining changes to LayerHandler |
|
Verified to work for both v2 and v4 auth. |
stevvooe
added a commit
that referenced
this pull request
Jan 15, 2015
Add functionality to make a url signed for a HEAD request to S4 driver
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until https://github.com/crowdmob/goamz/pull/319 is merged before merging this.
Update: It was merged.