Add readiness probe & set podManagementPolicy: Parallel & change service configuration #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatoliy-polivin-m10
approved these changes
Dec 19, 2023
This was referenced Dec 21, 2023
vcastellm
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, @vcastellm!
It seems that dkron needs some improvements to be usable in kubernetes.
This is one of them (I’ll open an issue about the others in the main repository).
podManagementPolicy: Parallel- this is necessary so that the cluster is created even if the readiness probe on the first deployed node does not pass.publishNotReadyAddresses: true- so that nodes can communicate for electionsIn essence, this is a consul-like approach - statefulset и service