Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ip changes #1446

Merged
merged 12 commits into from
Feb 3, 2024
Merged

Conversation

ivan-kripakov-m10
Copy link

Pull request is associated with issue #1442

I made several things here:

  1. add server_lookup and pass it to raft transport layer to provide possibility for ip changing in cluster (id -> ip mapping is updated on serf events)
  2. add serf member update handling
  3. resolve todo Query each of the servers and make sure they report no Raft peers. (I'm not sure if it is correct approach)
  4. Avoid self removing from raft cluster in leader loop because it leads to raft shutdown (on both add [don't remove if server id matches, just update configuration] and remove peer [skip if server id matches with current])

I built image and tested it in k8s using this helm - distribworks/dkron-helm#7
Seems like everything works fine now

@vcastellm
Copy link
Member

vcastellm commented Jan 3, 2024

Thanks your this contribution, really appreciated, can you add a simple test file to cover server_lookup?

Also, can you switch base branch to https://github.com/distribworks/dkron/tree/4.x branch instead? we'll focus on that at this point.

@ivan-kripakov-m10
Copy link
Author

yes, sure
done

@fieldju-harness
Copy link

@vcastellm how is this PR looking?

I'm trying to get a sense of when this might get merged and also a rough idea of when 4.x is coming.

@vcastellm
Copy link
Member

I'm trying to get a sense of when this might get merged and also a rough idea of when 4.x is coming.

First v4 beta in the following hours

Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great job!

@vcastellm vcastellm merged commit 1c45fdf into distribworks:4.x Feb 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants