Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "args.breadcrumbs" parameter #2554

Closed
raducoravu opened this issue Jan 4, 2017 · 2 comments
Closed

Remove the "args.breadcrumbs" parameter #2554

raducoravu opened this issue Jan 4, 2017 · 2 comments
Labels
bug enhancement Changes to an existing feature plugin/html5 Issue related to HTML5 plug-in plugin/xhtml Issue relate to XHTML plug-in priority/low Low priority issue
Milestone
2.4.2

Comments

@raducoravu
Copy link
Member

The parameter is documented and it connects to a parameter in the XSLT stylesheets called "BREADCRUMBS" which does nothing.
I think we should remove it, it is a source of confusion as we have users trying to set values to the parameter and expecting that it influences the output in some way.
@jelovirt
Copy link
Member

jelovirt commented Jan 4, 2017

The current code doesn't do anything with args.breadcrumbs, but we do want it to be possible to output breadcrumbs.

My preference is to remove args.breadcrumbs and BREADCRUMBS, since they don't work. If we at some point add support for toggling breadcrumbs with a parameter, we can use the old parameter names.

@jelovirt jelovirt added bug enhancement Changes to an existing feature plugin/html5 Issue related to HTML5 plug-in priority/low Low priority issue plugin/xhtml Issue relate to XHTML plug-in labels Jan 4, 2017
@raducoravu
Copy link
Member Author

Yes, no need to leave unimplemented parameters based on a future wish list.

jelovirt added a commit that referenced this issue Jan 4, 2017
@jelovirt
Remove args.breadcrumbs parameter #2554
1ad44a6 
The parameter has no associated implementation that will create breadcrumbs
navigation to HTML output.
@jelovirt jelovirt added this to the 2.4.2 milestone Jan 4, 2017
@jelovirt jelovirt closed this as completed Jan 4, 2017
infotexture added a commit to dita-ot/docs that referenced this issue Jan 5, 2017
@infotexture
Add info on dita-ot/dita-ot#2554 to 2.4.2 RN
b00bc5f 
Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture added a commit to dita-ot/docs that referenced this issue Jan 5, 2017
@infotexture
Merge branch 'hotfix/2.4.2'
91ec56f 
* hotfix/2.4.2:
  Add info on dita-ot/dita-ot#2548 to 2.4.2 RN
  Add info on dita-ot/dita-ot#2554 to 2.4.2 RN
  Sort issues in ascending order by issue number
  Add info on dita-ot/dita-ot#2547 to 2.4.2 RN
  Add info on dita-ot/dita-ot#2551 to 2.4.2 RN
  Add info on dita-ot/dita-ot#2542 to 2.4.2 RN
  Add info on dita-ot/dita-ot#1885 to 2.4.2 RN
  Add list of resolved issues to 2.4.2 Release Notes
  Bump 'maintenance-version' key to “2.4.2”
  Disable PDF output in default Gradle build task
  Update saxon-gradle plugin version to 0.2.1 (#126)
  Add info on roman ToC page number format in 2.2
  Restore CI builds from site plugin 'master' branch
  Define and extract line ranges for code blocks
  Use 'develop' branch of site plug-in for CI builds
  Use latest DITA-OT version (2.4.1) for CI builds
infotexture added a commit to dita-ot/docs that referenced this issue Jan 5, 2017
@infotexture
Merge branch 'hotfix/2.4.2' into develop
59ee1ac 
* hotfix/2.4.2:
  Add info on dita-ot/dita-ot#2548 to 2.4.2 RN
  Add info on dita-ot/dita-ot#2554 to 2.4.2 RN
  Sort issues in ascending order by issue number
  Add info on dita-ot/dita-ot#2547 to 2.4.2 RN
  Add info on dita-ot/dita-ot#2551 to 2.4.2 RN
  Add info on dita-ot/dita-ot#2542 to 2.4.2 RN
  Add info on dita-ot/dita-ot#1885 to 2.4.2 RN
  Add list of resolved issues to 2.4.2 Release Notes
  Bump 'maintenance-version' key to “2.4.2”
infotexture added a commit to dita-ot/docs that referenced this issue Dec 19, 2019
@infotexture
Remove reference to obsolete breadcrumbs parameter
6fc926d 
Removed from DITA-OT 2.4.2 per dita-ot/dita-ot#2554.

Signed-off-by: Roger Sheen <roger@infotexture.net>
@jason-fox jason-fox mentioned this issue Jan 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement Changes to an existing feature plugin/html5 Issue related to HTML5 plug-in plugin/xhtml Issue relate to XHTML plug-in priority/low Low priority issue
Projects
None yet
Milestone
2.4.2
Development

No branches or pull requests
2 participants
@jelovirt @raducoravu