Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DITA + Markdown publishing fail - "No renderer configured for com.vladsch.flexmark.ext.typographic.TypographicSmarts" #2866

Closed
raducoravu opened this issue Dec 19, 2017 · 8 comments
Labels
duplicate This issue or pull request already exists
Milestone

Comments

@raducoravu
Copy link
Member

Using DITA OT 3.0.1 to publish a small DITA project which contains a markdown topic to PDF fails with:

        BUILD FAILED
        C:\Users\radu_coravu\Desktop\DITA OT newest\dita-ot-3.0.1\build.xml:45: The following error occurred while executing this line:
        C:\Users\radu_coravu\Desktop\DITA OT newest\dita-ot-3.0.1\plugins\org.dita.base\build_preprocess2.xml:176: java.lang.RuntimeException: No renderer configured for com.vladsch.flexmark.ext.typographic.TypographicSmarts
        	at com.elovirta.dita.markdown.DitaRenderer$MainNodeRenderer.renderNode(DitaRenderer.java:498)
        	at com.elovirta.dita.markdown.DitaRenderer$MainNodeRenderer.renderChildrenNode(DitaRenderer.java:512)
        	at com.elovirta.dita.markdown.DitaRenderer$MainNodeRenderer.renderChildren(DitaRenderer.java:504)
        	at com.elovirta.dita.markdown.renderer.CoreNodeRenderer.printTag(CoreNodeRenderer.java:1321)
        	at com.elovirta.dita.markdown.renderer.CoreNodeRenderer.render(CoreNodeRenderer.java:772)
        	at com.elovirta.dita.markdown.renderer.CoreNodeRenderer.lambda$getNodeRenderingHandlers$42(CoreNodeRenderer.java:186)
        	at com.elovirta.dita.markdown.renderer.NodeRenderingHandler.render(NodeRenderingHandler.java:16)
        	at com.elovirta.dita.markdown.DitaRenderer$MainNodeRenderer.renderNode(DitaRenderer.java:491)
        	at com.elovirta.dita.markdown.DitaRenderer$MainNodeRenderer.renderChildrenNode(DitaRenderer.java:512)
        	at com.elovirta.dita.markdown.DitaRenderer$MainNodeRenderer.renderChildren(DitaRenderer.java:504)
        	at com.elovirta.dita.markdown.renderer.CoreNodeRenderer.render(CoreNodeRenderer.java:323)
        	at com.elovirta.dita.markdown.renderer.CoreNodeRenderer.lambda$getNodeRenderingHandlers$20(CoreNodeRenderer.java:164)
        	at com.elovirta.dita.markdown.renderer.NodeRenderingHandler.render(NodeRenderingHandler.java:16)
        	at com.elovirta.dita.markdown.DitaRenderer$MainNodeRenderer.renderNode(DitaRenderer.java:473)
        	at com.elovirta.dita.markdown.DitaRenderer$MainNodeRenderer.render(DitaRenderer.java:386)
        	at com.elovirta.dita.markdown.DitaRenderer.render(DitaRenderer.java:150)
        	at com.elovirta.dita.markdown.MarkdownReader.parseAST(MarkdownReader.java:273)
        	at com.elovirta.dita.markdown.MarkdownReader.parse(MarkdownReader.java:184)
        	at org.xml.sax.helpers.XMLFilterImpl.parse(Unknown Source)
        	at org.xml.sax.helpers.XMLFilterImpl.parse(Unknown Source)
        	at org.xml.sax.helpers.XMLFilterImpl.parse(Unknown Source)
        	at org.xml.sax.helpers.XMLFilterImpl.parse(Unknown Source)
        	at org.xml.sax.helpers.XMLFilterImpl.parse(Unknown Source)
        	at org.xml.sax.helpers.XMLFilterImpl.parse(Unknown Source)
        	at org.xml.sax.helpers.XMLFilterImpl.parse(Unknown Source)
        	at org.xml.sax.helpers.XMLFilterImpl.parse(Unknown Source)
        	at org.dita.dost.module.reader.AbstractReaderModule.readFile(AbstractReaderModule.java:356)
        	at org.dita.dost.module.reader.AbstractReaderModule.processWaitList(AbstractReaderModule.java:285)
        	at org.dita.dost.module.reader.TopicReaderModule.execute(TopicReaderModule.java:71)

Attached samples:

testFailMDTypographic.zip

@raducoravu
Copy link
Member Author

This worked with the previous version of the Markdown plugin (the one before using the flexmark libs).

@robander
Copy link
Member

robander commented Jan 2, 2018

I'm guessing this should be reported at https://github.com/jelovirt/org.lwdita

@raducoravu
Copy link
Member Author

I added an issue for it also on the separate project. But as this plugin is now distributed with the DITA OT I somehow now see it part of the DITA OT and its issues list.

@robander
Copy link
Member

robander commented Jan 3, 2018

I added an issue for it also on the separate project. But as this plugin is now distributed with the DITA OT I somehow now see it part of the DITA OT and its issues list.

Yeah I think that's one problem we're likely to encounter a lot with separate repositories for part of the code (most people just see it as "one project" regardless of where the parts come from).

Regardless - closing this one now that the issue is open in the other repo, which is where the fix will need to happen.

@robander robander closed this as completed Jan 3, 2018
@infotexture infotexture added the duplicate This issue or pull request already exists label Jan 28, 2018
infotexture referenced this issue Jan 28, 2018
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@StanDoherty
Copy link

StanDoherty commented Feb 7, 2018

FWIW -- the same error messages appears in 3.0.2 when I attempt to build any map with <topicref>s to Markdown files.

@dita-ot dita-ot deleted a comment from StanDoherty Feb 7, 2018
@infotexture infotexture added this to the 3.0.2 milestone Feb 7, 2018
@infotexture
Copy link
Member

I am not able to reproduce this with 3.0.2.

Markdown topics are now properly built with the dita command, even when they contain typographic quotation marks, so the changes for LwDITA plug-in v2.0.2 in jelovirt/org.lwdita@2c01572 are effective.

@StanDoherty How are you running the build? — Perhaps with Ant?

P.S. I edited your comment to display the <topicref> part (and removed the followup comment).

@dxcook5
Copy link

dxcook5 commented Feb 28, 2018

I still see this issue building with 3.0.2 with Oxygen (running Ant). I get the same error as that in the original post.

@grundrauschen
Copy link

I got the same issue in 3.0.2 depending on the format flag.
When using format="mdita" in the map everything worked fine. When I used format="markdown" though, the same error as above appeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

6 participants