Fix workdir-uri generation bug #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelovirt
added
bug
priority/medium
Make sure URI for a directory will always end in a trailing slash. If the File points to a path that doesn't exist, File.toURI() will not output a trailing slash. Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
force-pushed
the
feature/workdir-uri-trailing-slash-bug
branch
from
baf8a22
to
bb1c751
Compare
robander
approved these changes
Oct 31, 2020
This statement conflicts with the title of this issue. I'm guessing "not" is a typo and should be "now." The code seems to reflect the title. Just want to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure URI for a directory will always end in a trailing slash.
Motivation and Context
If a
Filepoints to a path that doesn't exist,File.toURI()will not output a trailing slash. This PR fixes that.How Has This Been Tested?
Tests pass and added a new test for
toDirURIfunction.Type of Changes
Documentation and Compatibility
None