New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PDF product name overrides for #2293 #2693

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
2 participants
@robander
Member

robander commented May 16, 2017

The $productName variable is set globally in the PDF code, and then used in many places (headers, footers, etc).

If product name metadata is specified in the map, that name is used to set the variable with xsl:value-of. If you want to modify the product name in any way (typically by supporting keywords that should generate extra text, as with the ™ character in #2293), there is no way to do so without overriding every use of $productName (default code today uses it in 17 named templates).

This pull request uses the existing text-only mode to ensure elements that add text are supported. This doesn't directly address ™, but it does pick up changes from similar elements and means that a simple override can add ™ into those 17 contexts.

Signed-off-by: Robert D Anderson robander@us.ibm.com

Enable PDF product name overrides #2293
Signed-off-by: Robert D Anderson <robander@us.ibm.com>

@robander robander added this to the 2.5 milestone May 23, 2017

@jelovirt jelovirt merged commit 6780a17 into dita-ot:develop May 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@robander robander deleted the robander:hotfix/2293 branch May 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment