Enable PDF product name overrides for #2293 #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelovirt
requested changes
May 22, 2017
| <xsl:when test="$mapProdname"> | ||
| <xsl:value-of select="$mapProdname"/> | ||
| <xsl:when test="exists($mapProdname)"> | ||
| <xsl:apply-templates select="$mapProdname" mode="dita-ot:text-only"/> |
There was a problem hiding this comment.
Should this be mode="set-product-name"?
jelovirt
added
enhancement
Signed-off-by: Robert D Anderson <robander@us.ibm.com>
jelovirt
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$productNamevariable is set globally in the PDF code, and then used in many places (headers, footers, etc).If product name metadata is specified in the map, that name is used to set the variable with
xsl:value-of. If you want to modify the product name in any way (typically by supporting keywords that should generate extra text, as with the ™ character in #2293), there is no way to do so without overriding every use of$productName(default code today uses it in 17 named templates).This pull request uses the existing
text-onlymode to ensure elements that add text are supported. This doesn't directly address ™, but it does pick up changes from similar elements and means that a simple override can add ™ into those 17 contexts.Signed-off-by: Robert D Anderson robander@us.ibm.com