LQ should indent by default #3009 #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robander
added
plugin/pdf
Signed-off-by: Robert D Anderson <robander@us.ibm.com>
jelovirt
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Causes output from
<lq>to be indented by default in PDF. Current formatting is no different than a paragraph. Implemented as requested in #3009.Motivation and Context
Default style makes it impossible to tell the difference between a
<lq>content...</lq>and<p>content...</p>. It should be possible to control the indenting in a customization by adding values to the existinglqattribute set, but that isn't actually used.The most common style for indented long quotes is to indent the block, which is the default browser rendition for HTML5, so I've added a default indent. I'm not sure what should be standard, but by calling the attribute set, anybody who wants more or less indent can add this to the
lqattribute set.How Has This Been Tested?
3009.zip
Type of Changes
Not sure this really counts as "breaking" but it does change existing behavior.