Add --plugins argument to dita command line #1960 #3037
Conversation
| private void printPlugins() { | ||
| final List<String> installedPlugins = getInstalledPlugins(); | ||
| if (installedPlugins != null) { | ||
| System.out.println("The following DITA-OT plugins are installed:"); |
There was a problem hiding this comment.
I'm not sure if I want to have this line output and each ID prefixed with spaces. My preference would be to just have one ID per line, without any prefixes. That way the output could be piped to other processes without parsing out the pretty printing.
This is basically plumbing vs porcelain distinction.
There was a problem hiding this comment.
I don't have a strong feeling on it, either is fine.
When I got the first one working it didn't have spaces, and that seemed to look a little odd in my DOS shell. I put in the 3 spaces because they matched the --help output. But ... yeah it's easy to convince me to remove them here.
There was a problem hiding this comment.
The question is, for what is the output used for. In the original request
This would also allow for scripts that can check dependencies and current installation status in support of coordinated installation of multiple plugins.
This sounds like request for plumbing output.
There was a problem hiding this comment.
@robander should we then change the output be plumbing output, i.e. only output the plug-in IDs or trantype names, without prefix?
There was a problem hiding this comment.
I think that's probably a good idea -- just generate the list, one per line, no extra spacing.
|
Added support for listing trantypes from CLI, IMO that's in the same class or requirement as listing plugins. @robander are you ok with this addition? |
Signed-off-by: Robert D Anderson <robander@us.ibm.com>
Since the list is used only once, it doesn't make sense to use lazy loading for the list. Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
force-pushed
the
feature/1960pluginlist
branch
from
92359ce
to
76168e8
Compare
👍 yes, was hoping we'd get that included as well. |
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Implemented in the 3.2 release cycle: - dita-ot/dita-ot#1960 - dita-ot/dita-ot#3037 Signed-off-by: Roger Sheen <roger@infotexture.net>
Signed-off-by: Robert D Anderson robander@us.ibm.com
Description
Adds a new command line arguments
--pluginsand--transtypesto theditacommand line. When used, they provide a list of installed plug-in IDs and transtype names, one per line.Pretty sure my implementation could be improved, but I won't know until I open the pull request and wait for the comments...
Motivation and Context
Requested in #1960 along with follow-up discussion.
There is also a request for an option that would display a list of transform types, but that is not (yet) part of this request - waiting to see how the
--pluginsimplementation goes over.How Has This Been Tested?
Tested by running the command line
bin/dita --pluginsandbin/dita --transtypes, verifying that each installed plugin is listed.Type of Changes
Checklist
Have not updated unit tests - I don't see unit tests for the other command line parameters so not sure where this one should go.