-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LwDITA XDITA to distribution #3108
Conversation
I tested this by installing the new XDITA plug-in manually:
I then built output from org.oasis-open.xdita/samples/remotelighting.ditamap, which failed with an error related to the use of footnotes on Line22 of remote-components.md:
Commenting out the offending topic on Line 15 of remotelighting.ditamap reveals errors with HDITA input: [xslt] file:/…/org.oasis-open.xdita/samples/hdita/intro-network-lighting.html:182:3:
[DOTX074W][WARN]: No formatting defined for unknown class attribute value
"- topic/title ".
[xslt] file:/…/org.oasis-open.xdita/samples/hdita/considerations.html:182:3:
[DOTX074W][WARN]: No formatting defined for unknown class attribute value
"- topic/title ". Commenting out both of these HDITA files on Lines 14 and 21 allow the build to complete successfully. |
The LwDITA committee note 2.0 introduces the MDITA footnote behavior after PHP Markdown Extra syntax. Jarno's original Markdown plugin did not have that behavior. |
Signed-off-by: Robert D Anderson <robander@us.ibm.com>
a82657d
to
be7a84b
Compare
@carlosevia Can you comment on the HDITA errors shown above that appear when publishing the Should that be filed as an issue in the upstream dita-lwdita/org.oasis-open.xdita repo? |
@infotexture Something I noticed is that both files have an HTML heading 2 that should map to a section in DITA... that could be breaking it |
We also need to check support in the OT for HDITA keyrefs and conrefs. I don't know what is functional as of today. |
paging @jelovirt … |
Haven't read the spec, haven't implemented anything. To be added later. |
I will fix the HDITA errors and then we can talk. |
@carlosevia Are the HDITA errors something that can be fixed in the sample files? I'd like to link to these samples from the docs, so it would be nice if we could get them to build without errors in time for the 3.2 release next weekend. |
Errors fixed... new release coming soon |
👍 @carlosevia resolved HDITA warnings with oasis-tcs/dita-lwdita@f5eec1f. 🙏 |
Signed-off-by: Robert D Anderson robander@us.ibm.com
Adds the Lightweight DITA XDITA document types as a plugin. This adds out-of-the-box processing support for documents that use the pre-release XDITA document types.
The plugin is pulled from the latest XDITA release (created today): https://github.com/oasis-tcs/dita-lwdita/releases/tag/v0.2.1
I haven't yet been able to test this properly - whenever I try to build the distribution package on my system I get Java failures (also true before this update):