Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for including project files in project files #3262

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Add support for including project files in project files #3262

merged 2 commits into from
Mar 25, 2019

Conversation

jelovirt
Copy link
Member

Description

Add support for import/include functionality to compose project files.

Motivation and Context

Being able to import/include common project file components into a project files enables project file reuse.

@jelovirt
Add project factory that loads and resolves includes
0e1cbdd 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt jelovirt self-assigned this Mar 25, 2019
@jelovirt jelovirt added feature New feature or request priority/medium Medium (or unknown) priority issue project Project configuration labels Mar 25, 2019
@jelovirt jelovirt added this to In progress in Project configuration via automation Mar 25, 2019
raducoravu
raducoravu reviewed Mar 25, 2019
View reviewed changes
Copy link
Member

@raducoravu raducoravu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, so includes will be expanded in place like entity references. Do you want to add also some kind of infinite recursive avoidance if you end up with cyclic references?

@jelovirt
Copy link
Member Author

Yeah, recursive include detection will need to be added. The code can just pass a Set of processed project file URIs, that's the easiest way to stop recursion and log it.

@jelovirt
Detect recursive read
83ea4ef 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt
Copy link
Member Author

@raducoravu Added recursion detection.

Project configuration automation moved this from In progress to Reviewer approved Mar 25, 2019
raducoravu
raducoravu approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@raducoravu raducoravu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jelovirt jelovirt marked this pull request as ready for review March 25, 2019 07:49
@jelovirt jelovirt merged commit d0e6197 into develop Mar 25, 2019
Project configuration automation moved this from Reviewer approved to Done Mar 25, 2019
@jelovirt jelovirt deleted the feature/import-project branch March 25, 2019 12:07
@jelovirt jelovirt added this to the 3.4 milestone Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducoravu raducoravu raducoravu approved these changes

Assignees

@jelovirt jelovirt

Labels
feature New feature or request priority/medium Medium (or unknown) priority issue project Project configuration
Projects
No open projects
Project configuration
  
Done
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jelovirt @raducoravu