Pass base context URI when processing links #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelovirt
requested changes
Jun 13, 2019
| @@ -696,7 +700,10 @@ mode="topicpull:figure-linktext" and mode="topicpull:table-linktext" | |||
| <xsl:if test="exists($shortdesc) and not(normalize-space($shortdesc) = '')"> | |||
| <xsl:apply-templates select="." mode="topicpull:add-genshortdesc-PI"/> | |||
| <desc class="- topic/desc "> | |||
| <xsl:apply-templates select="$shortdesc"/> | |||
| <xsl:apply-templates select="$shortdesc"> | |||
| <!-- EXM-42721 Pass the base context element. --> | |||
|
DCO is missing. |
jelovirt
added
bug
preprocess
priority/medium
|
Could you squash the commits and use descriptive commit message, the current "Update topicpullImpl.xsl" is a bit generic. |
Signed-off-by: Radu Coravu <radu_coravu@sync.ro> Update topicpullImpl.xsl Signed-off-by: Radu Coravu <radu_coravu@sync.ro>
jelovirt
approved these changes
Jun 22, 2019
|
@raducoravu Does this resolve #3078, or are there aspects of that issue unaddressed by these changes? |
|
@infotexture there are still cases in which the warning is shown, I gave more details and a sample in #3078. But the warning seems to be benign in that case so maybe we should leave this as such. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for:
#3078