Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer public IDs when comparing grammar descriptors #3574

Merged
merged 4 commits into from Sep 8, 2020
Merged

Prefer public IDs when comparing grammar descriptors #3574

merged 4 commits into from Sep 8, 2020

Conversation

raducoravu
Copy link
Member

Fix for #3568 Prefer public IDs when comparing descriptions for grammars stored in grammar cache.
If we have DTD-based DITA topics located in different folders using public IDs to refer to the DTDs the parser should be able to re-use the DTD grammars between them.

Signed-off-by: Radu Coravu radu_coravu@sync.ro


name: Pull request
about: Propose changes to fix an issue or implement a new feature


Description

Motivation and Context

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that changes existing functionality)

Documentation and Compatibility

  • What documentation changes are needed for this feature?
    (Provide links to existing documentation topics that will require updates)
  • Will this change affect backwards compatibility or other users' overrides?

Checklist

…mars stored in grammar cache.

Signed-off-by: Radu Coravu <radu_coravu@sync.ro>
@raducoravu raducoravu added this to the 3.5.4 milestone Sep 4, 2020
@raducoravu raducoravu added this to In progress in 3.5.4 via automation Sep 8, 2020
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
3.5.4 automation moved this from In progress to Reviewer approved Sep 8, 2020
@raducoravu raducoravu merged commit 24ca4ec into dita-ot:hotfix/3.5.4 Sep 8, 2020
3.5.4 automation moved this from Reviewer approved to Done Sep 8, 2020
@jelovirt jelovirt added the priority/medium Medium (or unknown) priority issue label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug preprocess priority/medium Medium (or unknown) priority issue
Projects
No open projects
3.5.4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants