Replace path2project PI with calculating up path from source file path #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelovirt
added
priority/medium
jelovirt
force-pushed
the
feature/refactor-path-processing-instructions
branch
from
48b5a23
to
a1156c4
Compare
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
The PI is not used anywhere. Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
force-pushed
the
feature/refactor-path-processing-instructions
branch
from
a1156c4
to
966907a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
<?path2project?>processing instruction with calculating up path from source file path.Motivation and Context
The path processing instructions are an old feature and are used only by transtype specific XSLT. The same functionality can be achieved by passing the path of the current document into the XSLT process. Refactoring the path processing instruction out and replacing with XSLT parameters, the code will be more simple and easier to reason.
Generation of
<?path2project?>processing instruction can be removed in future PR for the next major release.How Has This Been Tested?
Existing tests.
Type of Changes
Documentation and Compatibility
Requires a longer explanation in the release notes about migration to new code. Migration is only needed if custom plug-ins change how transtype specific XSLT are called from Ant or use the PIs during preprocessing.