Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise log messages for #3973 #4287

Merged
merged 52 commits into from Jan 7, 2024
Merged

Revise log messages for #3973 #4287

merged 52 commits into from Jan 7, 2024

Commits on Dec 29, 2023

  1. Fix spurious trailing bracket in code comment 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    bf0c14e View commit details
    Browse the repository at this point in the history

  2. Add blank lines between messages for readability 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    b5a358c View commit details
    Browse the repository at this point in the history

  3. Normalize whitespace 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    3cdb976 View commit details
    Browse the repository at this point in the history

  4. End all reason elements with periods 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    d90b4e7 View commit details
    Browse the repository at this point in the history

  5. Sort messages by ID within files 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    95e046a View commit details
    Browse the repository at this point in the history

  6. Use single quotes for '%' placeholders 

    - The single-quote form is used more often than the double-quote form, so this commit applies that form consistently
- Skip placeholders in pseudo-XML attribute="value" references, as those will be replaced in a later step
- Add quotes to unquoted placeholders

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    9736df0 View commit details
    Browse the repository at this point in the history

  7. Mark unused message duplicates as deprecated 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    70e35ae View commit details
    Browse the repository at this point in the history

  8. Use XML-domain notation for attribute references 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    08e3c57 View commit details
    Browse the repository at this point in the history

  9. Align additional attribute references 

    - quoted references
- attribute references at message start

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    73a7986 View commit details
    Browse the repository at this point in the history

  10. Rephrase XML excerpts as attribute references 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    a2fbf06 View commit details
    Browse the repository at this point in the history

  11. Edit additional attribute/argument/property refs 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    d3676d1 View commit details
    Browse the repository at this point in the history

  12. Use XML-domain notation for element references 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    94bddbd View commit details
    Browse the repository at this point in the history

  13. Align references to DITA and DITAVAL files 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    9734701 View commit details
    Browse the repository at this point in the history

  14. Replace "tag" references with "element" 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    e15ff30 View commit details
    Browse the repository at this point in the history

  15. Replace pseudo-code with attribute references 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    90f5e1d View commit details
    Browse the repository at this point in the history

  16. Remove redundant “toolkit” reference 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    b07b156 View commit details
    Browse the repository at this point in the history

  17. Update “file” references to “resource” 

    Per #3973:
> the DITA specification uses "resource" and it is more accurate in many cases

- Not all resources are files
- Leave “file” references to DITAVAL files, file encoding, image files, and log files

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    6531a8f View commit details
    Browse the repository at this point in the history

  18. Rephrase XML excerpts as attribute references 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    594fd1f View commit details
    Browse the repository at this point in the history

  19. Align “couldn’t” & “could not” → “cannot” 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    5914166 View commit details
    Browse the repository at this point in the history

  20. Copyedit messages 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    994d783 View commit details
    Browse the repository at this point in the history

  21. Use double quotes for explicit attribute value references 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    ceff989 View commit details
    Browse the repository at this point in the history

  22. Reduce “your” — users often process others’ files 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    6dcbefd View commit details
    Browse the repository at this point in the history

  23. Copyedit additional messages 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    9d239cc View commit details
    Browse the repository at this point in the history

  24. Fix hyphenation 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    5bfb9f6 View commit details
    Browse the repository at this point in the history

  25. Expand empty response elements 

    Per #4287 (comment)

Most are expanded, so this aligns those that were collapsed.

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    eaa32fa View commit details
    Browse the repository at this point in the history

  26. Simplify language: ensure → check 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    a667273 View commit details
    Browse the repository at this point in the history

  27. Align “check” references in responses 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    e5d92ab View commit details
    Browse the repository at this point in the history

  28. Implement review feedback 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    5862b1b View commit details
    Browse the repository at this point in the history

  29. Align conref push terms with spec 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    1df8b3f View commit details
    Browse the repository at this point in the history

  30. Drop pleasantries for brevity 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    8621225 View commit details
    Browse the repository at this point in the history

  31. Rephrase to avoid future tense 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    15a19b3 View commit details
    Browse the repository at this point in the history

  32. Copyedit for consistency 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    bcb5abd View commit details
    Browse the repository at this point in the history

  33. Align XHTML messages 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    2169eb9 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2023

  1. Replace “ensure” references 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    6384d18 View commit details
    Browse the repository at this point in the history

  2. Replace pseudo-code in PDF messages 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    a99cb94 View commit details
    Browse the repository at this point in the history

  3. Align additional messages for consistency 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    9bb9566 View commit details
    Browse the repository at this point in the history

  4. Move extra info from <reason> to <response> 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    739eefc View commit details
    Browse the repository at this point in the history

  5. Re-use DOTJ063E <response> 

    Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    169cfa5 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Implement review feedback on DOTJ033E 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    c81717c View commit details
    Browse the repository at this point in the history

  2. Clarify additional details for DOTJ025E & DOTJ026E 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    0cbb2a1 View commit details
    Browse the repository at this point in the history

  3. Implement review feedback on DOTJ043W 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    e526b0a View commit details
    Browse the repository at this point in the history

  4. Implement review feedback on DOTJ055E 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    51919f0 View commit details
    Browse the repository at this point in the history

  5. Implement review feedback on DOTJ065I 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    2097993 View commit details
    Browse the repository at this point in the history

  6. Align grammar file references 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    29b45c5 View commit details
    Browse the repository at this point in the history

  7. Implement review feedback on DOTX010E 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    3ea9e58 View commit details
    Browse the repository at this point in the history

  8. Implement review feedback on DOTX016W 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    49aab47 View commit details
    Browse the repository at this point in the history

  9. Implement review feedback on DOTX022W 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    f903806 View commit details
    Browse the repository at this point in the history

  10. Implement review feedback on DOTX042I & DOTX055W 

    Per
- #4287 (comment)
- #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    56b3f7c View commit details
    Browse the repository at this point in the history

  11. Implement review feedback on DOTX058W 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    7e17193 View commit details
    Browse the repository at this point in the history

  12. Implement review feedback on DOTX061W 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    5e00d3d View commit details
    Browse the repository at this point in the history

  13. Implement review feedback on DOTX071W 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    8623f89 View commit details
    Browse the repository at this point in the history

  14. Implement review feedback on DOTJ038E 

    Per #4287 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
    @infotexture
    infotexture committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    89a6446 View commit details
    Browse the repository at this point in the history