Add extension points to preprocess2 #4395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
commented
Feb 11, 2024
| @@ -51,6 +51,10 @@ See the accompanying LICENSE file for applicable license. | |||
| <!-- Deprecated since 2.1 --> | |||
| <extension-point id="depend.preprocess.copy-subsidiary.pre" name="Copy subsidiary pre-target"/> | |||
| <extension-point id="depend.preprocess.post" name="Preprocessing post-target"/> | |||
| <extension-point id="depend.preprocess2.maps.pre" name="Map-first pre-processing maps pre-target"/> | |||
There was a problem hiding this comment.
@infotexture The copy needs to be better 😄 I'm not sure if we actually use these anywhere, but might as well come up with a good copy for the description.
There was a problem hiding this comment.
Let's follow the pattern we use in the docs for the other Pre-processing extension points:
Suggested change
| <extension-point id="depend.preprocess2.maps.pre" name="Map-first pre-processing maps pre-target"/> | |
| <extension-point id="depend.preprocess2.maps.pre" name="Runs an Ant target before pre-processing maps"/> |
robander
approved these changes
Feb 11, 2024
infotexture
requested changes
Feb 11, 2024
| @@ -51,6 +51,10 @@ See the accompanying LICENSE file for applicable license. | |||
| <!-- Deprecated since 2.1 --> | |||
| <extension-point id="depend.preprocess.copy-subsidiary.pre" name="Copy subsidiary pre-target"/> | |||
| <extension-point id="depend.preprocess.post" name="Preprocessing post-target"/> | |||
| <extension-point id="depend.preprocess2.maps.pre" name="Map-first pre-processing maps pre-target"/> | |||
There was a problem hiding this comment.
Let's follow the pattern we use in the docs for the other Pre-processing extension points:
Suggested change
| <extension-point id="depend.preprocess2.maps.pre" name="Map-first pre-processing maps pre-target"/> | |
| <extension-point id="depend.preprocess2.maps.pre" name="Runs an Ant target before pre-processing maps"/> |
| @@ -51,6 +51,10 @@ See the accompanying LICENSE file for applicable license. | |||
| <!-- Deprecated since 2.1 --> | |||
| <extension-point id="depend.preprocess.copy-subsidiary.pre" name="Copy subsidiary pre-target"/> | |||
| <extension-point id="depend.preprocess.post" name="Preprocessing post-target"/> | |||
| <extension-point id="depend.preprocess2.maps.pre" name="Map-first pre-processing maps pre-target"/> | |||
| <extension-point id="depend.preprocess2.maps.post" name="Map-first pre-processing maps post-target"/> | |||
There was a problem hiding this comment.
Suggested change
| <extension-point id="depend.preprocess2.maps.post" name="Map-first pre-processing maps post-target"/> | |
| <extension-point id="depend.preprocess2.maps.post" name="Runs an Ant target after pre-processing maps"/> |
| @@ -51,6 +51,10 @@ See the accompanying LICENSE file for applicable license. | |||
| <!-- Deprecated since 2.1 --> | |||
| <extension-point id="depend.preprocess.copy-subsidiary.pre" name="Copy subsidiary pre-target"/> | |||
| <extension-point id="depend.preprocess.post" name="Preprocessing post-target"/> | |||
| <extension-point id="depend.preprocess2.maps.pre" name="Map-first pre-processing maps pre-target"/> | |||
| <extension-point id="depend.preprocess2.maps.post" name="Map-first pre-processing maps post-target"/> | |||
| <extension-point id="depend.preprocess2.topics.pre" name="Map-first pre-processing topics pre-target"/> | |||
There was a problem hiding this comment.
Suggested change
| <extension-point id="depend.preprocess2.topics.pre" name="Map-first pre-processing topics pre-target"/> | |
| <extension-point id="depend.preprocess2.topics.pre" name="Runs an Ant target before pre-processing topics"/> |
| <extension-point id="depend.preprocess2.maps.pre" name="Map-first pre-processing maps pre-target"/> | ||
| <extension-point id="depend.preprocess2.maps.post" name="Map-first pre-processing maps post-target"/> | ||
| <extension-point id="depend.preprocess2.topics.pre" name="Map-first pre-processing topics pre-target"/> | ||
| <extension-point id="depend.preprocess2.topics.post" name="Map-first pre-processing topics post-target"/> |
There was a problem hiding this comment.
Suggested change
| <extension-point id="depend.preprocess2.topics.post" name="Map-first pre-processing topics post-target"/> | |
| <extension-point id="depend.preprocess2.topics.post" name="Runs an Ant target after pre-processing topics"/> |
|
@jelovirt We should probably take this as an opportunity to review the extension point descriptions that we pushreplace from the docs repo and move them to the core repo (but we can treat that as a separate issue): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add extension points to preprocess2 to allow running targets between map and topic processing.
Motivation and Context
Fixes #4394
Type of Changes
Documentation and Compatibility
To be listed in extension point list for preprocess2.