[DIT-4270] Support pulling multiple formats at once #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if specified: - takes precedence over any value specified for the `format` property - fetches and saves data in both `.strings` and `.stringsdict` formats - does not generate a `.js` driver file
azjgard
changed the title
.strings and .stringsdict files together.strings and .stringsdict files together
azjgard
changed the title
.strings and .stringsdict files together.strings and .stringsdict files together
azjgard
changed the title
.strings and .stringsdict files together
asnewman
approved these changes
Jun 27, 2023
lib/types.ts
Outdated
| @@ -21,6 +21,7 @@ export type SupportedFormat = | |||
| | "icu"; | |||
|
|
|||
| export interface ConfigYAML { | |||
| mode?: "ios"; | |||
There was a problem hiding this comment.
oops, left behind from original implementation
azjgard
commented
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for optionally specifying a list of formats in the
formatproperty.Context
https://linear.app/dittowords/issue/DIT-4270/pull-down-strings-and-stringsdict
Test Plan
config.yml, confirm you can pull a single format likeformat: flatconfig.yml, confirm you can pull multiple formats like