Counting no.of nodes in list through recursion and iteration #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemanth-kotagiri
requested changes
Oct 2, 2021
There was a problem hiding this comment.
Hey, @ShreyaDayma-cse. I appreciate your efforts, but there's a lot that needs to be said of your PR.
General Suggestions:
- Always review Contrubition Guidelines of any repository before you raise a PR.
- You have not raised an Issue regarding your implementation - and it's essential for the issue to be created before you raising a PR and it also needs to be assigned to you.
Code Review:
- Please have proper naming conventions with regard to file names.
- Since you are implementing recursive and iterative approaches, you can either maintain two different PRs or add the implementations as two different methods in the
sameclass with thepropermethod names.
| new_node.next = null; | ||
| if (list.head == null) { | ||
| list.head = new_node; | ||
| } else { |
There was a problem hiding this comment.
Please format your code properly before you commit your next changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
What have you Changed(must)
Write here what you have changed in codebase
Issue no.(must) -
Pr will be closed and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)
README - How to Contribute