Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added API schema and documentation #100

Merged
merged 1 commit into from
May 13, 2021

Conversation

Sachin-chaurasiya
Copy link
Contributor

Describe your changes :


I worked on the API documentation and schema because it is mandatory to have good documentation of An API.

Type of change :

  • New feature

Preview (Screenshots) :

MumbleAPI-Doc

Checklist:

  • I have read the Code Of Conduct document.
  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Documentation: @MidouWebDev, @abhivemp

@MidouWebDev
Copy link
Collaborator

@abhivemp i reviewed the requirements.txt, please review the other files (.py)

@abhivemp abhivemp added the documentation Improvements or additions to documentation label May 13, 2021
@abhivemp
Copy link
Collaborator

@Sachin-chaurasiya thanks for your PR! I'll pull your branch and get back to you.
@MidouWebDev sounds good mate

@MidouWebDev
Copy link
Collaborator

@abhivemp great !
Thanks

@divanov11 divanov11 merged commit 131ffb5 into divanov11:master May 13, 2021
@Sachin-chaurasiya Sachin-chaurasiya deleted the api-documentation branch May 15, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants