Reset productDetails before request #10
Open
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes same thing happens with me
…On Fri, 14 May 2021, 2:35 pm Sanghyuk Jeong, ***@***.***> wrote:
Hey Dennis I really enjoyed your Udemy course!
I found a minor bug which is about ProductScreen component.
To explain how to see the bug,
1. At the first time you click product from the HomeScreen, works just
fine in ProductScreen component, but from the second times, it doesn't work
anymore.
2. If you go back and choose other items, somehow doesn't work, and it
also shows previous item infos for a short time(which bothers me).
This PR will fix the bug.
cheers!
Sanghyuk from Korea.
------------------------------
You can view, comment on, or merge this pull request online at:
#10
Commit Summary
- Reset productDetails before request
File Changes
- *M* frontend/src/actions/productActions.js
<https://github.com/divanov11/proshop_django/pull/10/files#diff-8bfc6d95272f3175c49db7886c7e0f68e1fd61030ce9a1c59bbb09e6df374e2a>
(2)
- *M* frontend/src/constants/productConstants.js
<https://github.com/divanov11/proshop_django/pull/10/files#diff-dd57fb27dca01b9c713c1ccbdc7c023b37fa8a3f4eaded59bf1ddc085b9e8f98>
(1)
- *M* frontend/src/reducers/productReducers.js
<https://github.com/divanov11/proshop_django/pull/10/files#diff-761d3d1b00b7e97b694e10cbe943edd1ecf83522cdd92207336e9f1fa0d315f5>
(4)
Patch Links:
- https://github.com/divanov11/proshop_django/pull/10.patch
- https://github.com/divanov11/proshop_django/pull/10.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APNBYSOZLIEVR7WJ325INH3TNTRWHANCNFSM444CCZXQ>
.
|
|
@mrcaption49 These three changes fixed the bug :) hopefully it will work on yours too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Dennis I really enjoyed your Udemy course!
I found a minor bug which is about ProductScreen component.
To explain how to see the bug,
This PR will fix the bug.
cheers!
Sanghyuk from Korea.