Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Null object in array #25

Merged
merged 4 commits into from
Jan 16, 2019
Merged

WIP: Null object in array #25

merged 4 commits into from
Jan 16, 2019

Conversation

jonaskello
Copy link
Member

Graphql may return null for an object in an array. This is not handled today.

@jonaskello jonaskello changed the title Null object in array WIP: Null object in array Jan 16, 2019
@jonaskello jonaskello self-assigned this Jan 16, 2019
@Jontem
Copy link
Contributor

Jontem commented Jan 16, 2019

What happended before when an object was null in an array?

@jonaskello
Copy link
Member Author

There was an exception before. I think the first place it manifested was when it tried to do getObjectId(null).

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #25 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   91.59%   91.76%   +0.17%     
==========================================
  Files           4        4              
  Lines         238      243       +5     
  Branches       75       77       +2     
==========================================
+ Hits          218      223       +5     
  Misses         20       20
Impacted Files Coverage Δ
src/entity-cache.ts 69.69% <ø> (ø) ⬆️
src/denormalize.ts 98.57% <100%> (+0.04%) ⬆️
src/normalize.ts 98.27% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382b6bd...4aa145d. Read the comment docs.

@jonaskello jonaskello merged commit 1e8d77c into master Jan 16, 2019
@jonaskello jonaskello deleted the fix/null-object-in-array branch January 16, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants