Saturday Vespers

[GoogleCodeExporter]

For Saturday, 9/24: Vespers should be First Vespers of the Sunday, not of the 
Ember Day.  Perhaps a script could be written so that for 1955 and 1960, Ember 
Saturday in September ends after None.

Also for Saturday, 8/6, Vespers should be of the Transfiguration, not of the 
Sunday. This may necessitate a special script in Perl when the decision is made 
as to what happens at Vespers.

Original issue reported on code.google.com by APMarcel...@gmail.com on 24 Sep 2011 at 9:13

[GoogleCodeExporter]

It might not be a bad idea if we could program in the rules of concurrence and 
occurrence for the 1960 rubrics.

Original comment by canon.mi...@gmail.com on 2 Oct 2011 at 1:18

[GoogleCodeExporter]

Original comment by a...@malton.name on 2 Oct 2011 at 2:06

• Added labels: Component-Ordo

[GoogleCodeExporter]

Several bugs seem to be at work here, and fixing them is likely to have 
unintended side-effects. I've created a branch called "precedence" for 
experimental fixes.

The first revision in the branch, r76, fixes the Ember Day bug mentioned above, 
but will require testing for unexpected effects elsewhere.

Original comment by igregord on 8 Oct 2011 at 8:43

[GoogleCodeExporter]

Another such bug: With the Divino afflatu rubrics, feasts of the Lord should 
take precedence over lesser Sundays. See, for example, 9-14-2008.

Original comment by igregord on 11 Oct 2011 at 8:09

[GoogleCodeExporter]

The precedence branch now corrects all of the bugs mentioned above. I have 
tested Matins and Vespers for the whole of 2008, and for some other small 
intervals, with both the 1960 and Divino afflatu rubrics, and the only changes 
to the offices were intentional. I'm happy to make any necessary further tests 
before the branch is merged to trunk, however.

The last change to the branch, r113, splits the conditional for determining 
whether the sanctoral or temporal office should take precedence into several 
conditionals that set a flag as appropriate. It had become unwieldy with the 
previous changes. Some of its logic was also redundant or incorrect, owing 
either to recent changes or (presumably) to earlier changes by Laszlo himself. 
The change makes the test more readable, but it is not terribly slick; I would 
welcome any suggestions for a neater solution.

Below is a summary of the changes on the branch:

- Respect the request of callers to &monthday to retrieve the following day's 
date (for Vespers and Compline of the following). Fixes the above Ember day 
bug. (r76)
- Fixed concurrence of feasts with Sundays according to the 1960 rubrics: 
second Vespers of a feast take precedence over first Vespers of a Sunday of 
equal rank. Fixes the Transfiguration bug. (r78)
- Feasts of the Lord often take precedence over Sundays, with the rules varying 
according to the set of rubrics. Fixes the Holy-Cross-day bug. (r102)
- Split up the conditional as noted above. (r113)

Original comment by igregord on 16 Oct 2011 at 6:40

[GoogleCodeExporter]

Merged to trunk in r129.

Original comment by igregord on 19 Oct 2011 at 8:06

• Changed state: Fixed