Skip to content
This repository has been archived by the owner on Dec 27, 2018. It is now read-only.

Adapt setup to work on AWS #53

Merged
merged 6 commits into from
Oct 21, 2015
Merged

Adapt setup to work on AWS #53

merged 6 commits into from
Oct 21, 2015

Conversation

FinalAngel
Copy link
Member

  • splits requirements to develop and master
  • works locally and on docker hub
  • still need to setup node create separate branch

@@ -1,7 +1,7 @@
Django>=1.8.5
django-cms>=3.1.3
django-reversion>=1.9.3 # not a part of django-cms core
djangocms-text-ckeditor>=2.6.0 # not a part of django-cms core
djangocms-text-ckeditor>=2.6.0 # not a part of django-cms core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsk tsk

@stefanfoulis
Copy link

why do the requirements need to be split?
Does it not make the tests less realistic if travis installs different requirements than the normal Dockerfile?

@FinalAngel
Copy link
Member Author

@stefanfoulis on travis we want the latest releases to pass, If there is an error we need to fix addons ASAP.
On docker and locally, we want the latest develop version to be installed so preview.django-cms.org shows our latest efforts. Optionally you can use make install REQUIREMENTS=master to also install latest releases on your local env.
I still need to adapt the requirements to use all develop versions, once the setup is up and running.

@stefanfoulis
Copy link

makes sense :-)

👍

as a later step it could be useful to use pip-compile (from pip-tools) to test all the requirements. That would also detect impossible combinations of dependencies (e.g one package says html5lib<0.10 and another html5lib>=0.999999). pip alone does not see such inconsistencies.

@FinalAngel
Copy link
Member Author

will keep that in mind @stefanfoulis thank you

FinalAngel added a commit that referenced this pull request Oct 21, 2015
@FinalAngel FinalAngel merged commit 17e1667 into master Oct 21, 2015
@FinalAngel FinalAngel deleted the feature/setup branch October 21, 2015 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants