Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_page_queryset_from_path() in cms/utils/page_resolver.py not 100% site aware #1573

Closed
barsch opened this issue Jan 7, 2013 · 2 comments
Closed

get_page_queryset_from_path() in cms/utils/page_resolver.py not 100% site aware #1573

barsch opened this issue Jan 7, 2013 · 2 comments

Comments

@barsch
Copy link
Contributor

barsch commented Jan 7, 2013

IMHO line no. 79 in https://github.com/divio/django-cms/blob/develop/cms/utils/page_resolver.py

should be changed from

try:
        home = pages.get_home()
    except NoHomeFound:
        home = None

to

try:
        home = pages.get_home(site=site)
    except NoHomeFound:
        home = None
@digi604
Copy link
Contributor

digi604 commented Jan 7, 2013

could you write a pull request?

@barsch barsch mentioned this issue Jan 7, 2013
Merged
@digi604
Copy link
Contributor

digi604 commented Jul 11, 2013

fixed in #1575

@digi604 digi604 closed this as completed Jul 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@digi604 @barsch