Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Putting language= in querystring breaks CMS pages #5651

Closed
stefanw opened this issue Sep 1, 2016 · 1 comment
Closed

Putting language= in querystring breaks CMS pages #5651

stefanw opened this issue Sep 1, 2016 · 1 comment
Labels
status: accepted status: has patch
Milestone
3.3.x

Comments

@stefanw
Copy link
Contributor

stefanw commented Sep 1, 2016

Adding a ?edit&language= on any CMS page leads to a NoReverseMatch error. See here for an example.

My best guess why this happens without looking deeper: the toolbar admin language is set to the empty string which breaks language-based reversing of URLs. Solution: better sanitation of the toolbar language input.
@czpython
Copy link
Contributor

czpython commented Sep 1, 2016

Thanks for reporting @stefanw.
I know I've seen this one before.. think it got lost in time.

@czpython czpython added this to the 3.3.x milestone Sep 1, 2016
vstoykov added a commit to IndustriaTech/django-cms that referenced this issue Sep 7, 2016
@vstoykov
Corectly get language from reqeust
27ee135 
If for some reason local variable language becomes empty string instead of None then treat is as None. (Duck typing)

Fixes django-cms#5651
@vstoykov vstoykov mentioned this issue Sep 7, 2016
Merged
vstoykov added a commit to IndustriaTech/django-cms that referenced this issue Sep 7, 2016
@vstoykov
Corectly get language from reqeust
224276c 
If for some reason local variable language becomes empty string instead of None then treat is as None. (Duck typing)

Fixes django-cms#5651
vstoykov added a commit to IndustriaTech/django-cms that referenced this issue Sep 7, 2016
@vstoykov
Corectly get language from reqeust
541c665 
If for some reason local variable language becomes empty string instead of None then treat is as None. (Duck typing)

Fixes django-cms#5651
czpython pushed a commit that referenced this issue Sep 7, 2016
@vstoykov @czpython
Fixed #5651 -- Correctly get language from request (#5664)
5f62966 
If for some reason local variable language becomes empty string instead of None then treat is as None. (Duck typing)

Fixes #5651
czpython pushed a commit to czpython/django-cms that referenced this issue Sep 7, 2016
@vstoykov @czpython
Fixed django-cms#5651 -- Correctly get language from request (django-…
52d8099 
…cms#5664)

If for some reason local variable language becomes empty string instead of None then treat is as None. (Duck typing)

Fixes django-cms#5651
nolsto pushed a commit to fusionbox/django-cms that referenced this issue Jan 5, 2017
@vstoykov @nolsto
Fixed django-cms#5651 -- Correctly get language from request (django-…
23e20d3 
…cms#5664)

If for some reason local variable language becomes empty string instead of None then treat is as None. (Duck typing)

Fixes django-cms#5651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepted status: has patch
Projects
None yet
Milestone
3.3.x
Development

No branches or pull requests
2 participants
@stefanw @czpython