Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image resizing fundamentally not working in most basic page setup #5668

Closed
ghost opened this issue Sep 7, 2016 · 4 comments
Closed

Image resizing fundamentally not working in most basic page setup #5668

ghost opened this issue Sep 7, 2016 · 4 comments

Comments

@ghost
Copy link

ghost commented Sep 7, 2016

To reproduce, do the following:

  1. Make a fresh virtualenv
  2. Install django and django-cms from pip (latest versions)
  3. Install django-cms using the djangocms installer tool
  4. Add a superuser using manage.py
  5. Launch django-cms and login as admin
  6. Add a new page
  7. Click "Edit"
  8. Click "Structure"
  9. Add a new "Text" content
  10. In the WYSIWYG editor, insert some text and then insert an image plugin
  11. Add a really big image (e.g. photo 4k x 4k or something)
  12. Click the image for the detailed properties and make sure Crop and Upscale are checked, and Automatic resize is unchecked. Click "Ok" to close again
  13. Resize the image in the WYSIWYG editor to a small size (like really small, try something around roughly 150 pixel) using the resize handlers and click "Save" on the text content
  14. Publish changes on the overview edit page

Expected result:
The image is as small as in the WYSIWYG editor

Actual result:
The image will be huge again on the resulting site (expected behavior is obviously: it remains small).
If you click "edit" again and click the edit button on the text content, in the WYSIWYG editor the image is small again. If you right-click > "Inspect" in your browser, you will see width/height tags with exact pixel dimensions is set on the instance displayed as part of the WYSIWYG content area. If you now return to the published page, no width/height tags are present on the rendered as part of the resulting page which seems to be really weird.

@czpython
Copy link
Contributor

czpython commented Sep 7, 2016

Hello @Jonast , I believe this is an issue with the image plugin you're using.
If it's cmsplugin-filer or djangocms-picture, please create a ticket there in those apps.

Thanks!

@czpython czpython closed this as completed Sep 7, 2016
@ghost
Copy link
Author

ghost commented Sep 7, 2016

I used your default install with your default choice of Image insertion. (I literally just clicked the button for content to insert and chose "Image".) I did zero work beyond just running the default installer with no extensions, other packages or anything

Do you expect me to know your internal project structure?? If this needs to be forwarded to some party, please do it yourself since I am just a user. You should really deal with bug reports of such basic functionality differently...

How should I even know which image plugin handles images per default??

@ghost
Copy link
Author

ghost commented Sep 7, 2016

Checking again in the editor, it seems to be in a "Filer" section, so I am going to assume it's "cmsplugin-filer"?

However, just to stress this: there is literally no other option available (for inserting images), and this is the most default install I could have done with pretty much zero changes, and inserting images is a super basic behavior in a CMS - I can file it somewhere else if you tell me where exactly, but I certainly can't guess the correct responsible component myself..

@czpython
Copy link
Contributor

czpython commented Sep 7, 2016

Hello @Jonast,
Thanks for looking into it.
I apologize for the confusion. There's the cms core and then all the other third party integrations, as such we are constantly making sure to only file cms core issues here and distribute the other issues to their respective party. That said, I can see that we need a better strategy for this as it can sometimes be tricky to know which party the issue originates from.

Regarding this specific issue, seems like the problem comes from the WYSIWYG editor, the resize handles are added by the editor js but I don't think these are hooked up to the backend, an oversight on our part.

I've filed a ticket for this django-cms/djangocms-text-ckeditor#362.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant