Added language_fallback behaviour to render_placeholder #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice one... Is PlaceholderConf the right place for this or more CMS_LANGUAGES? |
|
PlaceholderConf looks like the best option, so it can be a per-placeholder configuration. |
|
yep looks clean... |
|
could you add your change to the CHANGELOG? |
|
Added |
digi604
added a commit
that referenced
this pull request
May 30, 2013
Added language_fallback behaviour to render_placeholder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a per-placeholder option to fallback to fallback languages if the placeholder is empty for the current language.
This fixes #449 and supersedes #1329.
Thanks @lasarux for the code.