Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for non-ASCII characters in LANGUAGES.name #2048

Merged
merged 1 commit into from
Aug 23, 2013
Merged

Fix for non-ASCII characters in LANGUAGES.name #2048

merged 1 commit into from
Aug 23, 2013

Conversation

mkoistinen
Copy link
Contributor

#1803
Signed-off-by: Martin Koistinen mkoistinen@gmail.com

#1803
Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
@yakky
Copy link
Member

yakky commented Jul 14, 2013

Could you add a test for this?

@charettes
Copy link
Contributor

We better use django.utils.encoding.smart_unicode here.

yakky added a commit to yakky/django-cms that referenced this pull request Jul 26, 2013
yakky added a commit to yakky/django-cms that referenced this pull request Jul 26, 2013
@digi604
Copy link
Contributor

digi604 commented Aug 6, 2013

@yakky could you merge your changes and close the appropriate tickets/pull requests?

@yakky
Copy link
Member

yakky commented Aug 7, 2013

Sorry, I've polluted the PR with reference to commits which doesn't belong here (and that's already been merged).
This still need a test.
And smart_unicode is the way to go. I'll take care of this when I'll be back home

@ghost ghost assigned yakky Aug 7, 2013
@yakky
Copy link
Member

yakky commented Aug 23, 2013

Opened PR #2186 to merge this with some modifications

yakky added a commit to yakky/django-cms that referenced this pull request Aug 23, 2013
yakky added a commit that referenced this pull request Aug 23, 2013
Fix for non-ASCII characters in LANGUAGES.name

Fix #1803 
Fix #2048
@yakky yakky merged commit 2096b60 into django-cms:support/2.4.x Aug 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants