Fixing #1649 - NoReverseMatch raised if apphook doesn't exist #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some apps, like cmsplugin-zinnia and cmsplugin_news will raise NoReverseMatch when trying to generate their menus before an apphook is installed. In sampleapp this is solved by adding a try-except like the one in this commit. Placing the try-except in django-cms instead of inside every app would simplify the process of writing plugins and avoid some confusing 500-errors for new users trying to install plugins.
|
looks good to me |
|
Probably some kind of user feedback should be added here, swallowing exceptions is really nasty... |
| except NoReverseMatch: | ||
| # Apps might raise NoReverseMatch if an apphook does not yet | ||
| # exist, skip them instead of crashing | ||
| pass |
There was a problem hiding this comment.
use nodes = [] instead of pass. nodes variable must be inizialized
ghost
assigned 
|
#2156 adds a message feedback for the users (only visibile in the admin and when in draft mode) |
digi604
added a commit
that referenced
this pull request
Nov 25, 2013
Extends PR #2156 with feedback to users
|
I has same problem when i want call the website of blog. NoReverseMatch at /de/admin/r/46/2/ I has try to fix with that what is post here but the menu_pool.py is other as here stand. Django 1.6.4 Has someone an idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps, like cmsplugin-zinnia and cmsplugin_news will raise NoReverseMatch when trying to generate their menus before an apphook is installed. In sampleapp this is solved by adding a try-except like the one in this commit. Placing the try-except in django-cms instead of inside every app would simplify the process of writing plugins and avoid some confusing 500-errors for new users trying to install plugins.