Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for Issue 2213 #2773

Merged
merged 7 commits into from Mar 2, 2014
Merged

Test for Issue 2213 #2773

merged 7 commits into from Mar 2, 2014

Conversation

mkoistinen
Copy link
Contributor

This new test proves that #2213 isn't actually an issue in latest 3.0 commits. (Perhaps it was fixed already?)

@mkoistinen
Test that pages appear in the tree in the current lang
898ab56 
Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
@mkoistinen
Remove unused imports
3470d68 
Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
@mkoistinen mkoistinen mentioned this pull request Mar 1, 2014
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.12%) when pulling 3470d68 on mkoistinen:issue_2213 into 4339013 on divio:develop.

@mkoistinen
Copy link
Contributor Author

So... I wrote a test (only) and somehow, that decreased the test coverage for the project? Umm, I don't think that's how it works, coveralls!

@mkoistinen
Switch for .format() for string interpolation
945b5ae 
Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
@mkoistinen
Avoid use of str()
ec20cf3 
Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.12%) when pulling ec20cf3 on mkoistinen:issue_2213 into 4339013 on divio:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.12%) when pulling ec20cf3 on mkoistinen:issue_2213 into 4339013 on divio:develop.

@mkoistinen
wrap response.content in str() for Python3
4658bf9 
Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
@mkoistinen
Merge branch 'develop' of https://github.com/divio/django-cms into is…
d9c389a 
…sue_2213
@mkoistinen
Just delete unneeded import.
d654492 
Signed-off-by: Martin Koistinen <mkoistinen@gmail.com>
digi604 added a commit that referenced this pull request Mar 2, 2014
@digi604
Merge pull request #2773 from mkoistinen/issue_2213
51b3413 
Test for Issue 2213
@digi604 digi604 merged commit 51b3413 into django-cms:develop Mar 2, 2014
@mkoistinen mkoistinen deleted the issue_2213 branch March 2, 2014 13:46
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) when pulling d654492 on mkoistinen:issue_2213 into 03191b8 on divio:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkoistinen @coveralls @digi604