Fix corner case with Django 1.7 #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoids leaking patched db_table
yakky
force-pushed
the
feature/fix_dbtable
branch
from
624f328
to
12fbb50
Compare
|
@mkoistinen you target a 3.0.11 release at the end of the month, right? |
This was referenced Feb 22, 2015
Merged
|
@ojii @mkoistinen might have a few more eyeballs on this? |
| name='category', | ||
| parent=None | ||
| ) | ||
| self.assertEqual(len(example.description._get_attached_fields()), 1) |
There was a problem hiding this comment.
While you're at it, maybe also test that the attached field is the one you expect.
|
Here you go |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3891
Apparently use of the model reference lead to the
db_tableissue documented above.Passing it as string solves the issue.
The test checks a side effect of the above leak which leads to not returning attached fields for models with messed up
db_table