Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise 404 instead of returing it #4452

Closed
wants to merge 1 commit into from

Conversation

vstoykov
Copy link
Contributor

Fixes #4451

@yakky
Copy link
Member

yakky commented Sep 16, 2015

probably worth merging in support branches too

@evildmp
Copy link
Contributor

evildmp commented Sep 16, 2015

@vstoykov This should be covered by a test already (not sure where it would be exactly), but if there isn't one, we need one.

@vstoykov
Copy link
Contributor Author

I will try to find a proper place to put the test and will update my pull request

@yakky yakky modified the milestones: 3.0.X, 3.0.16 Sep 17, 2015
@mkoistinen
Copy link
Contributor

@vstoykov is this still on your radar?

@vstoykov
Copy link
Contributor Author

vstoykov commented Oct 8, 2015

Hi guys sorry for the delay. I was busy these days.

I also had some problems with running tests on my machine. I'm not sure if it is related with newer version of Firefox or something else but at the end I just ran the tests related to publishing process test_publisher (where I put my test).

I rebased my PR to current develop. I see that you put milestone 3.0.16 and this means that someone of you @yakky @mkoistinen will backport it right?

@yakky
Copy link
Member

yakky commented Oct 8, 2015

@vstoykov yes. Will do. Thanks for taking your time ti complete this pr

@vstoykov
Copy link
Contributor Author

There are some problems with the tests with which I'm not familiar. Can you guys check the output of the travis?

@vxsx
Copy link
Contributor

vxsx commented Oct 12, 2015

@vstoykov it seems some of the jobs were cancelled, I restarted them

@yakky
Copy link
Member

yakky commented Oct 12, 2015

@vstoykov all good now. @vxsx I'll merge first into support branch. I 'll take care of this

@yakky yakky self-assigned this Oct 12, 2015
@yakky yakky mentioned this pull request Oct 13, 2015
yakky added a commit that referenced this pull request Oct 13, 2015
@yakky
Copy link
Member

yakky commented Oct 14, 2015

Fixed in support. Will forward port
Thanks @vstoykov for reporting this!

@yakky yakky closed this Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants