-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise 404 instead of returing it #4452
Conversation
probably worth merging in support branches too |
@vstoykov This should be covered by a test already (not sure where it would be exactly), but if there isn't one, we need one. |
I will try to find a proper place to put the test and will update my pull request |
@vstoykov is this still on your radar? |
Hi guys sorry for the delay. I was busy these days. I also had some problems with running tests on my machine. I'm not sure if it is related with newer version of Firefox or something else but at the end I just ran the tests related to publishing process I rebased my PR to current |
@vstoykov yes. Will do. Thanks for taking your time ti complete this pr |
There are some problems with the tests with which I'm not familiar. Can you guys check the output of the travis? |
@vstoykov it seems some of the jobs were cancelled, I restarted them |
Fixed in support. Will forward port |
Fixes #4451