remove search_form template, adapt changelog and docs #4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the template is used from inside of admin templatetag it doesn't really work
| Django Admin issues | ||
| ------------------- | ||
|
|
||
| * In the page tree first touch on the page would open the keyboard because |
There was a problem hiding this comment.
We might want to describe that in a bit more detail @evildmp
There was a problem hiding this comment.
yeah, but i'm not the best person for this :(
|
LGTM |
|
I made minor tweaks for clarity in the known issues list. Otherwise LGTM. |
mkoistinen
added a commit
that referenced
this pull request
Nov 24, 2015
remove search_form template, adapt changelog and docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the template is used from inside of admin templatetag it doesn't
really work
https://github.com/django/django/blob/53ccffdb8c8e47a4d4304df453d8c79a9be295ab/django/contrib/admin/templatetags/admin_list.py#L407-L416