-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes clipboard not respecting parent restrictions #4914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
czpython
commented
Jan 13, 2016
- Cleanup toolbar code (reducing queries).
- Reduces queries in clipboard rendering.
- Fixes Parent restriction not respected in clipboard #4913
The render_plugin_toolbar_config tag will now be used to render the plugin's toolbar html config.
czpython
changed the title
Fixes/issue 4913
Fixes clipboard not respecting parent restrictions
Jan 13, 2016
2 tasks
Changelog? |
@vxsx because not everything has been updated in changelog, I decided to just go through my prs and update changelog individually prior to release. |
hmm although when I forward port this to 3.3.x would be good to have it there.. ok you win :) |
LGTM, does this pass manual testing? |
@mkoistinen yup. will also get @genti94 to test after merge. |
czpython
added a commit
that referenced
this pull request
Jan 14, 2016
Fixes clipboard not respecting parent restrictions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.