Remove some deprecation warnings #4998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakky
force-pushed
the
feature/deprecations
branch
5 times, most recently
from
e51bff9
to
81fa103
Compare
yakky
changed the title
|
please review @divio/django-cms-core (and @timgraham ) |
| request, "admin/cms/page/plugin/delete_confirmation.html", context, current_app=self.admin_site.name | ||
| ) | ||
| else: | ||
| return TemplateResponse( |
There was a problem hiding this comment.
Depending on the outcome of the flake8 max line length discusison, this is as example of where I'd use a single longer line (103 here).
yakky
force-pushed
the
feature/deprecations
branch
from
d1dbec8
to
14b4697
Compare
|
@divio/django-cms-core @timgraham I'm going to merge this tomorrow , if there are no more objections |
|
The latest update will fail until a workaround for https://code.djangoproject.com/ticket/26041 is merged into classytags |
yakky
force-pushed
the
feature/deprecations
branch
from
8d11f36
to
8089279
Compare
yakky
force-pushed
the
feature/deprecations
branch
from
8089279
to
aad4895
Compare
|
Failing test here due to infamous related_name issue, I will merge this as soon as test suite completes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More Django 1.9 work
Code should now be 100% deprecation warnings free
Tests still emits some (hunting down the remaining ones)