Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untitled #602

Merged
3 commits merged into from Nov 30, 2010
Merged

Untitled #602

3 commits merged into from Nov 30, 2010

Conversation

ghost
Copy link

@ghost ghost commented Nov 28, 2010

Hi, I've made some documentation suggestions. This is the first time I've tried contributing anything, so I'm unsure of the procedure. Ideally, I'd like to get start a conversation with whoever else is contributing to the documentation, to come to an agreement over document structure and content. For example, I think the tutorial.rst file could do with being broken up a bit.

sub-sections for template and javascript troubleshooting.
tutorial.rst modified in different places: additional installation
instructions covering pip & easy_install; additional section to
explain the CMS_MEDIA_URL and serving static media
@ojii
Copy link
Contributor

ojii commented Nov 29, 2010

why did you change all the section title underlining?

@chrisglass
Copy link
Contributor

Thanks a lot for your contribution!

So regarding the procedure, you got it spot on, it's exactly what you should do.
I agree with Ojii, changing the underlining is a bit strange, but well, I'm not going to be regarding this as disqualifying.

Please send me your real name by private message so that I add you to AUTHORS when I pull your change in :)

By the way, if you think you can make subsequent improvements to the docs, please do! As a rule of thumb, simply try to keep the pull requests small(ish), so that it's easier to see what you've done / correct / discuss.

Other than that, go nuts!

  • Chris

@ghost
Copy link
Author

ghost commented Nov 29, 2010

I'm very sorry about the changes to the underlining: I have no idea how it happened. It wasn't intentional... I was trying out emacs for the first time, and I'm guessing it has some sort of shortcut that made the change for me?! That's the only theory I've got... I can revert the underlining and re-commit if you like?

@chrisglass
Copy link
Contributor

Ah well, the underline thing isn't really a problem, I would have merged with it, no sweat :)

@ojii
Copy link
Contributor

ojii commented Nov 30, 2010

thanks again for your contribution

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants