'Quick Start' Dockerfile&docker-compose, HacktoberFest #6920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Quick Start' Dockerfile and Docker Compose added
YulianSalo
changed the title
YulianSalo
changed the title
|
@YulianSalo If you can update the branch to the latest code the test suite will pass. The failure that you are seeing is now added as an allowed failure. |
Aiky30
requested changes
Oct 29, 2020
There was a problem hiding this comment.
A changelog is needed and the branch needs to be brought up to date. We may need to look at how this new feature is added to the projects documentation. @FinalAngel Do you have any background as to why we have never implemented a Docker build before?
|
@marksweb Let's close this outdated PR, since it doesn't add any real value at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Quick Start' Dockerfile and Docker Compose added.
Description
Related resources
Checklist
develop