Fixed PlaceholderField frontend edit (#729) #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l/django-cms into finalangel-feature/toolbar-frontend
…-feature/toolbar-frontend
Added a view in the tests project to see the placeholder field frontend admin in action
|
Ooh niiiice! |
…r-frontend Ojii finalangel feature/toolbar frontend
|
I made a minor change, but unfortunately the feature still fails on a completely vanilla django-CMS. Here's what I did to test:
Fails without javascript errors (it just sits there doing nothing but showing the rotating "loading" image) |
|
Ok I found the exact condition for the problem: Adding FAILS if the "edit bar" is COLLAPSED (looking like a + sign in the top-right corner); |
…toolbar is currently hidden. On CMS.Placeholder.editPlugin, if the toolbar is currently hidden, show it for the edit process (and hide it again if necessary after the edit is done) Special thanks to @chrisglass for finding this weird edge case
|
Ok, LGTM, I'll merge it in :) By the way, the "flashing" green highlight when reordering plugins is badass. Thanks @FinalAngel :) |
added 2 commits
August 4, 2011 10:31
gave his okay for this. The reason behind this is NOT to take credit from @FinalAngel, but because over time there will be many authors to those files, also the license did not match the one of the CMS (though it was compatible).
chrisglass
added a commit
that referenced
this pull request
Aug 4, 2011
Fixed PlaceholderField frontend edit (#729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.